fix(events): add back support for #commentevent anchor#577
Merged
zzacharo merged 2 commits intoinveniosoftware:masterfrom Feb 17, 2026
Merged
fix(events): add back support for #commentevent anchor#577zzacharo merged 2 commits intoinveniosoftware:masterfrom
zzacharo merged 2 commits intoinveniosoftware:masterfrom
Conversation
palkerecsenyi
added a commit
to palkerecsenyi/invenio-rdm-records
that referenced
this pull request
Feb 17, 2026
* Added the `request_event_anchor` method to the `BaseRequest` from
which all RDM-specific request types inherit. This allows including the
`#commentevent-{id}` anchor at the end of the `self_html` link of
request events.
* This method is added in
inveniosoftware/invenio-requests#577. Please
release these two PRs simultaneously.
zzacharo
approved these changes
Feb 17, 2026
* The new links system we added in inveniosoftware#560 accidentally stopped including `#commentevent-{id}` anchor in the `self_html` link of request events. This has now been added back by using the builtin `anchor` attribute on the `EndpointLink` class. * This does not support reply deep links (added in inveniosoftware#548) since they are not yet on master, currently only on the `maint-v11.x` branch. This avoids breaking instances that are already using invenio-requests v12.x.
palkerecsenyi
force-pushed
the
request-event-anchor
branch
from
3bc9a94 to
5ab66ed
Compare
palkerecsenyi
added a commit
to palkerecsenyi/invenio-rdm-records
that referenced
this pull request
Feb 17, 2026
* Added the `request_event_anchor` method to the `BaseRequest` from
which all RDM-specific request types inherit. This allows including the
`#commentevent-{id}` anchor at the end of the `self_html` link of
request events.
* This method is added in
inveniosoftware/invenio-requests#577. Please
release these two PRs simultaneously.
zzacharo
pushed a commit
to inveniosoftware/invenio-rdm-records
that referenced
this pull request
Feb 17, 2026
* Added the `request_event_anchor` method to the `BaseRequest` from
which all RDM-specific request types inherit. This allows including the
`#commentevent-{id}` anchor at the end of the `self_html` link of
request events.
* This method is added in
inveniosoftware/invenio-requests#577. Please
release these two PRs simultaneously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release together with inveniosoftware/invenio-rdm-records#2255
The new links system we added in context plus utc plus links #560 accidentally stopped including
#commentevent-{id}anchor in theself_htmllink of request events. This has now been added back by using the builtinanchorattribute on theEndpointLinkclass.This does not support reply deep links (added in Deep link into replies #548) since they are not yet on master, currently only on the
maint-v11.xbranch. This avoids breaking instances that are already using invenio-requests v12.x.