Merged
Conversation
This was referenced Feb 6, 2026
This was referenced Feb 6, 2026
zzacharo
reviewed
Feb 6, 2026
ptamarit
force-pushed
the
feature/comments-files
branch
3 times, most recently
from
72f8b8d to
134df9e
Compare
zzacharo
approved these changes
Feb 9, 2026
ptamarit
force-pushed
the
feature/comments-files
branch
from
134df9e to
77a4eef
Compare
Member
Author
|
Added a commit to lazily initialize the files field for requests created before file support. |
Member
Author
Co-authored-by: Pablo Tamarit <[email protected]>
ptamarit
force-pushed
the
feature/comments-files
branch
from
eb96d97 to
fbe35be
Compare
Member
Author
|
Rebased after #574 was merged in order to fix conflicts (the 2 cherry-picked commits mentioned above are now not part of this PR anymore). |
palkerecsenyi
approved these changes
Feb 17, 2026
Member
palkerecsenyi
left a comment
palkerecsenyi
left a comment
There was a problem hiding this comment.
Looks perfect! :) Just the eslint complaints and then I think we can merge
ptamarit
force-pushed
the
feature/comments-files
branch
from
fbe35be to
5e1c50b
Compare
Member
|
Tests failing due to known dependency issue with |
palkerecsenyi
pushed a commit
to palkerecsenyi/invenio-requests
that referenced
this pull request
Feb 17, 2026
* feat(comment-file): file upload delete read * feat(comment-file): file read UI URL * feat(comment-file): comment-file association * feat(comment-file): allow inline images in comments * feat(comment-file): file details expansion Co-authored-by: Pablo Tamarit <[email protected]> * feat(comment-file): user interface * feat(comment-file): lazy files initialization * fix: timeline event body forward ref (displayName) --------- Co-authored-by: zzacharo <[email protected]>
palkerecsenyi
pushed a commit
to palkerecsenyi/invenio-requests
that referenced
this pull request
Feb 17, 2026
* feat(comment-file): file upload delete read * feat(comment-file): file read UI URL * feat(comment-file): comment-file association * feat(comment-file): allow inline images in comments * feat(comment-file): file details expansion Co-authored-by: Pablo Tamarit <[email protected]> * feat(comment-file): user interface * feat(comment-file): lazy files initialization * fix: timeline event body forward ref (displayName) --------- Co-authored-by: zzacharo <[email protected]>
palkerecsenyi
pushed a commit
to palkerecsenyi/invenio-requests
that referenced
this pull request
Feb 17, 2026
* feat(comment-file): file upload delete read * feat(comment-file): file read UI URL * feat(comment-file): comment-file association * feat(comment-file): allow inline images in comments * feat(comment-file): file details expansion Co-authored-by: Pablo Tamarit <[email protected]> * feat(comment-file): user interface * feat(comment-file): lazy files initialization * fix: timeline event body forward ref (displayName) --------- Co-authored-by: zzacharo <[email protected]>
palkerecsenyi
pushed a commit
to palkerecsenyi/invenio-requests
that referenced
this pull request
Feb 18, 2026
* feat(comment-file): file upload delete read * feat(comment-file): file read UI URL * feat(comment-file): comment-file association * feat(comment-file): allow inline images in comments * feat(comment-file): file details expansion Co-authored-by: Pablo Tamarit <[email protected]> * feat(comment-file): user interface * feat(comment-file): lazy files initialization * fix: timeline event body forward ref (displayName) --------- Co-authored-by: zzacharo <[email protected]>
palkerecsenyi
pushed a commit
to palkerecsenyi/invenio-requests
that referenced
this pull request
Feb 18, 2026
* feat(comment-file): file upload delete read * feat(comment-file): file read UI URL * feat(comment-file): comment-file association * feat(comment-file): allow inline images in comments * feat(comment-file): file details expansion Co-authored-by: Pablo Tamarit <[email protected]> * feat(comment-file): user interface * feat(comment-file): lazy files initialization * fix: timeline event body forward ref (displayName) --------- Co-authored-by: zzacharo <[email protected]>
palkerecsenyi
pushed a commit
to palkerecsenyi/invenio-requests
that referenced
this pull request
Feb 20, 2026
* feat(comment-file): file upload delete read * feat(comment-file): file read UI URL * feat(comment-file): comment-file association * feat(comment-file): allow inline images in comments * feat(comment-file): file details expansion Co-authored-by: Pablo Tamarit <[email protected]> * feat(comment-file): user interface * feat(comment-file): lazy files initialization * fix: timeline event body forward ref (displayName) --------- Co-authored-by: zzacharo <[email protected]>
palkerecsenyi
pushed a commit
to palkerecsenyi/invenio-requests
that referenced
this pull request
Feb 25, 2026
* feat(comment-file): file upload delete read * feat(comment-file): file read UI URL * feat(comment-file): comment-file association * feat(comment-file): allow inline images in comments * feat(comment-file): file details expansion Co-authored-by: Pablo Tamarit <[email protected]> * feat(comment-file): user interface * feat(comment-file): lazy files initialization * fix: timeline event body forward ref (displayName) --------- Co-authored-by: zzacharo <[email protected]>
zzacharo
added a commit
that referenced
this pull request
Feb 25, 2026
* feat(comment-file): file upload delete read * feat(comment-file): file read UI URL * feat(comment-file): comment-file association * feat(comment-file): allow inline images in comments * feat(comment-file): file details expansion Co-authored-by: Pablo Tamarit <[email protected]> * feat(comment-file): user interface * feat(comment-file): lazy files initialization * fix: timeline event body forward ref (displayName) --------- Co-authored-by: zzacharo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes commits from: