uvx marimo convert for a first notebook#75
Open
tschm wants to merge 13 commits intointro-stat-learning:mainfrom
Open
uvx marimo convert for a first notebook#75tschm wants to merge 13 commits intointro-stat-learning:mainfrom
tschm wants to merge 13 commits intointro-stat-learning:mainfrom
Conversation
tschm
changed the title
| permissions: | ||
| contents: read | ||
|
|
||
| on: |
Collaborator
There was a problem hiding this comment.
I still think it's overkill to do this on push -- manual trigger seems more reasonable. Any change to the lab source should be tested prior to pushing. Maybe on creating a tag?
Contributor
Author
There was a problem hiding this comment.
Creating a tag should be very restricted. Only you should have that power. Given a few students work with your notebooks, you may want to expose 'make test' and something smart during ci/cd, e.g. testing only notebooks that have been changed.
Contributor
Author
|
Manual trigger is something you can run on your side. I think the testing has to be a bit more automated and sophisticated, e.g. test only notebooks that have been changed (in addition to manual testing of them all?). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create an empty marimo folder for experiments