Fix accessing state in initState when not mounted.#324
Merged
Conversation
jwr1
approved these changes
Dec 5, 2025
Member
jwr1
left a comment
jwr1
left a comment
There was a problem hiding this comment.
Thanks. I really wish Flutter didn't throw those kinds of errors. We shouldn't have to check if the widget is mounted every time we want to call setState (it should check automatically).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mounted checks in
initStatein case of instances when widget is scrolled out of view before async function returns.Shouldn't need to add checks for setting state in button callbacks etc since its unlikely for the associated widget to be unmounted before the callback is completed.
Came across this after pressing 'Back to top' from far down on a feed. The quick scrolling resulted in a lot of null check operator errors.