Conversation
jwr1
requested changes
May 14, 2025
Member
jwr1
left a comment
jwr1
left a comment
There was a problem hiding this comment.
Thanks, I actually did look into using Hero over a year ago (although it was for opening the whole post, not the image), so I'm glad you were able to loop back to this.
Contributor
Author
|
Would you like me to add another hero animation for whole posts as well as images? |
Member
Sure, might as well! |
Change hero animation duration to default.
Contributor
Author
|
That should fix the animation issues. The problem was flutter can't animate between different BoxFits so keeping the same fit between image and image page and using Center to keep the image contained should solve the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a hero widget to advanced image to give an animation when opening an image or navigating to an image post.
The 'hero' parameter in AdvancedImage is so cross posted images have an unique tag otherwise they don't animate properly when multiple of the same image are shown in a feed.