Merged
Conversation
Add reply action.
Enable reply action from feed screen. Enable autofocus for markdown editor.
jwr1
requested changes
Mar 29, 2025
Member
There was a problem hiding this comment.
Looks great so far, just have a few points:
- Could you change the way it's stored in the profile to be four separate fields, instead of an array? I don't think we'd ever have any more or less than four options, so I think it's fine to do it that way. Changing it away from an array would also mean you wouldn't have to use those
var newActions = List<SwipeAction>.fromlines in multiple places. - Could you change the names of the settings to make it more obvious which gesture it's changing? Like use "Left" and "Right" in the names. Not exactly sure how to differentiate the ones that are on the same side though. Maybe "Short" and "Long"? And then also use the new name as the key in the profile as well.
- Could you make it so the autofocus in the markdown editor is an optional parameter? I certainly agree it should be auto focused in certain contexts, like while replying, but in others, like creating a post, there are other fields as well, and it shouldn't really be automatically focused.
- Also, I like the upvote and boost being on the left, but could you have a bookmark (short) and reply (long) on the right as the default?
jwr1
requested changes
Mar 29, 2025
Member
There was a problem hiding this comment.
I know this would be more work, but could you also add the swipe actions to the ContentItemCompactPost widget as well, as that's the kind of context where it would really be best in. Maybe you could extract out the changes you made to the ContentItem widget to a separate "wrapper" widget, which would make it easy to implement for both content item widgets without duplicating code.
Remove SwipeAction list in profile. Change swipe setting names to left/right short/long combinations. Change swipe action defaults.
Add swipe gestures to compact posts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds customizable swipe gestures to content items. Currently available actions include