[PB-1974]: Feature/draft emails#68
Merged
Merged
Conversation
jzunigax2
reviewed
Jun 22, 2026
| threading?: ThreadingHeaders, | ||
| ): Promise<{ id: string }> { | ||
| if (dto.draftId) { | ||
| console.log('THERE IS A DRAFT ID'); |
| this.resolveMailboxId(userEmail, 'sent'), | ||
| ]); | ||
|
|
||
| console.log('SUBMIT EXISTING DRAFT', draftId); |
Comment on lines
+588
to
+590
| if (!existingDraft) { | ||
| throw new Error('Draft not found'); | ||
| } |
Contributor
There was a problem hiding this comment.
I believe this isn't catched anywhere, meaning this gets surfaced to the client as a 500 when it should be a 404. I dont believe this file should import nest's not found error and throw from here though
|
jzunigax2
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new EPs to save a Draft, update a Draft, Send a Draft and discard a Draft.