[PB-6492]:feat/new banners for storage advertisement#2002
Open
jaaaaavier wants to merge 7 commits into
Open
Conversation
Deploying drive-web with
|
| Latest commit: |
25a34ee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f98a60a9.drive-web.pages.dev |
| Branch Preview URL: | https://feat-progressive-free-usage.drive-web.pages.dev |
|
xabg2
reviewed
Jun 23, 2026
| containerClassName: 'pb rounded-lg bg-alert border border-alert-dark', | ||
| advertisementKey: 'modals.reachingUsageBanner.highWarning.sidenavStorageText', | ||
| }, | ||
| ]; |
Contributor
There was a problem hiding this comment.
Maybe it could be better to centralize this Stages with this one. Something like STORAGE_STAGES_CONFIG and export them whenever you need them and use it as you wish.
| import ReferralBanner from './ReferralBanner'; | ||
| import { CloudWarning } from '@phosphor-icons/react'; | ||
|
|
||
| type StorageWarning = 'lowWarning' | 'midWarning' | 'highWarning'; |
Contributor
There was a problem hiding this comment.
This component does to many things. Extract them to a custom hook to handle the warning logic, to a utils file if needed, etc.
| workspaceUuid: selectedWorkspace?.workspaceUser.workspaceId, | ||
| }); | ||
| dispatch(uiActions.setIsPreferencesDialogOpen(true)); | ||
| window.open('https://internxt.com/specialoffer', '_blank', 'noopener,noreferrer'); |
Contributor
There was a problem hiding this comment.
Extract this URL to a constants file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we have replaced the WarningMessage that previously appeared when the maximum capacity of the free plan was reached, and we now have a series of banners that appear depending on how the plan is being used; we have three thresholds: 60%, 80% and 95%. The idea is that as a user reaches these thresholds, the banner is displayed (never immediately after a usage spike, but always afterwards). The banner designs have already been added to the UI repository, and here we are customising them according to our requirements – text, shape, colours, etc. The banners have certain conditions under which they are hidden: they remain hidden for 7 days when usage is low, and for 3 days for the other two thresholds we have. We’ve had to add new colours to the library.
The SidenavWrapper component has also been updated, as it forms part of this system.
Related Issues
Related Pull Requests
Checklist
Testing Process
To test it, we created a free account and uploaded files to exceed the thresholds once we’d passed each one, we checked that the banners did indeed appear when and how they should, and that they were working correctly
Additional Notes