Skip to content

DRAFT: Series WIP#8677

Closed
cdrini wants to merge 5 commits intointernetarchive:masterfrom
cdrini:feature/series
Closed

DRAFT: Series WIP#8677
cdrini wants to merge 5 commits intointernetarchive:masterfrom
cdrini:feature/series

Conversation

@cdrini
Copy link
Collaborator

@cdrini cdrini commented Dec 30, 2023

Depends on #8627 .

Closes #6160
Closes #7812

Feature. Adds the ability to add markdown notes to list seeds.

Technical

  • Introduces a BREAKING CHANGE to our schema for lists. Previously, list seeds could be only two types: a ThingReferenceDict (eg { key: "/books/OL1M" }), or a SeedSubjectString (eg "subject:sci_fi"). We now have a new option, an AnnotatedSeedDict which is eg { thing: { key: "/books/OL1M" }, notes: 'My notes!' }.
  • The changes have been carefully designed to support the old formats as well, so adding notes to a list seed will not cause every seed on the list to be modified. This will allow history to be reasonable and avoid confusing unintentional edits.

Testing

Screenshot

image
image

Stakeholders

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ad32a9) 16.66% compared to head (f4a7d78) 16.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8677   +/-   ##
=======================================
  Coverage   16.66%   16.66%           
=======================================
  Files          88       88           
  Lines        4686     4686           
  Branches      835      835           
=======================================
  Hits          781      781           
  Misses       3389     3389           
  Partials      516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini changed the title Ability to add notes to list seeds DRAFT: Series WIP Jan 4, 2024
@cdrini cdrini mentioned this pull request May 31, 2025
@RayBB
Copy link
Collaborator

RayBB commented Feb 12, 2026

I know you've been working hard on series lately. I think the PR here is way outdated and your new one probably takes it's place.
Please reopen if I'm mistaken
#11678

@RayBB RayBB closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Annotated List Seeds: Extend list seeds to allow extra annotations Lists: Adding notes to seed

3 participants