feat: add clientset for DLRover#1720
Open
zhengxle wants to merge 1 commit intointelligent-machine-learning:masterfrom
Open
feat: add clientset for DLRover#1720zhengxle wants to merge 1 commit intointelligent-machine-learning:masterfrom
zhengxle wants to merge 1 commit intointelligent-machine-learning:masterfrom
Conversation
Author
|
Hi @BalaBalaYi @workingloong, this PR introduces the typed clientset which has been verified in production at Zhejiang Lab with MetaX GPUs. Could you please help to approve the workflow and review the changes? Thanks! |
c9e77c0 to
f17d424
Compare
f17d424 to
66df47f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces a generated typed clientset, along with informers and listers, for the DLRover
elasticjobresource (v1alpha1).Specifically, the following components were added:
go/elasticjob/client/clientset. Provides a type-safe way to interact withElasticJobresources.register.goanddoc.goingo/elasticjob/api/v1alpha1to ensure proper scheme registration.hack/update-codegen.sh: A professional-grade utility script to automate the generation of DeepCopy, Clientset, Listers, and Informers.Why are the changes needed?
Does this PR introduce any user-facing change?
Yes (for developers). Users can now utilize the typed clientset to interact with
ElasticJobresources.How was this patch tested?
go build ./client/clientset/...andgo mod tidyagainst the latest upstream master in thego/elasticjobdirectory.