Skip to content

feat: add clientset for DLRover#1720

Open
zhengxle wants to merge 1 commit intointelligent-machine-learning:masterfrom
zhengxle:feat-add-clientset
Open

feat: add clientset for DLRover#1720
zhengxle wants to merge 1 commit intointelligent-machine-learning:masterfrom
zhengxle:feat-add-clientset

Conversation

@zhengxle
Copy link
Copy Markdown

@zhengxle zhengxle commented Mar 29, 2026

What changes were proposed in this pull request?

This PR introduces a generated typed clientset, along with informers and listers, for the DLRover elasticjob resource (v1alpha1).

Specifically, the following components were added:

  • Clientset: Located in go/elasticjob/client/clientset. Provides a type-safe way to interact with ElasticJob resources.
  • Informers & Listers: Added to support efficient resource caching and event-driven controller logic.
  • API Registration: Included register.go and doc.go in go/elasticjob/api/v1alpha1 to ensure proper scheme registration.
  • Added hack/update-codegen.sh: A professional-grade utility script to automate the generation of DeepCopy, Clientset, Listers, and Informers.

Why are the changes needed?

Does this PR introduce any user-facing change?

Yes (for developers). Users can now utilize the typed clientset to interact with ElasticJob resources.

How was this patch tested?

  • In-situ Validation: Successfully tested and deployed within the Zhejiang Lab infrastructure.
  • Compilation Check: Passed go build ./client/clientset/... and go mod tidy against the latest upstream master in the go/elasticjob directory.

@zhengxle
Copy link
Copy Markdown
Author

Hi @BalaBalaYi @workingloong, this PR introduces the typed clientset which has been verified in production at Zhejiang Lab with MetaX GPUs. Could you please help to approve the workflow and review the changes? Thanks!

@zhengxle zhengxle force-pushed the feat-add-clientset branch from c9e77c0 to f17d424 Compare March 29, 2026 14:30
@zhengxle zhengxle changed the title feat: add clientset and update vendor dependencies for DLRover feat: add clientset for DLRover Mar 30, 2026
@zhengxle zhengxle force-pushed the feat-add-clientset branch from f17d424 to 66df47f Compare March 30, 2026 01:50
@zhengxle zhengxle marked this pull request as draft March 30, 2026 01:54
@zhengxle zhengxle marked this pull request as ready for review March 30, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant