Fix unexpected success failures for Conv/RefOps tests on XPU#3200
Open
PatrykWilczewski wants to merge 1 commit intointel:mainfrom
Open
Fix unexpected success failures for Conv/RefOps tests on XPU#3200PatrykWilczewski wants to merge 1 commit intointel:mainfrom
PatrykWilczewski wants to merge 1 commit intointel:mainfrom
Conversation
Several tests marked as expectedFailure for CUDA now pass on XPU, causing "Unexpected success" failures. Add passing ops to _cuda_xfail_xpu_pass to suppress the inherited expectedFailure decorator: - nn.Conv2d, nn.ConvTranspose2d, nn.LazyConv2d, nn.LazyConvTranspose2d for test_memory_format (device_type='cuda', dtypes=[float64]) - _refs.pow for test_python_ref_executor (device_type=None, dtypes=[complex32]) Extend gen_xpu_wrappers to also strip expectedFailure decorators that have device_type=None when the (op_name, test_name) pair is listed in _cuda_xfail_xpu_pass. This is needed because _refs.mul and _refs.pow mark test_python_ref_executor as expectedFailure without scoping to a specific device type. Fixes: intel#2537
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses “Unexpected success” failures in XPU test runs caused by inheriting CUDA (and unscoped) expectedFailure decorators for ops that now pass on XPU. It does so by expanding the allowlist of (op, test) pairs that should not carry over those xfails to XPU, and by teaching the wrapper generator to also drop unscoped (device_type=None) expectedFailure decorators for those pairs.
Changes:
- Add Conv/LazyConv module entries to
_cuda_xfail_xpu_passfortest_memory_format. - Add
_refs.powentry to_cuda_xfail_xpu_passfortest_python_ref_executor. - Extend
gen_xpu_wrappersto stripexpectedFailuredecorators withdevice_type=Nonewhen the (op, test) pair is in_cuda_xfail_xpu_pass.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several tests marked as expectedFailure for CUDA now pass on XPU, causing "Unexpected success" failures.
Add passing ops to _cuda_xfail_xpu_pass to suppress the inherited expectedFailure decorator:
Extend gen_xpu_wrappers to also strip expectedFailure decorators that have device_type=None when the (op_name, test_name) pair is listed in _cuda_xfail_xpu_pass. This is needed because _refs.mul and _refs.pow mark test_python_ref_executor as expectedFailure without scoping to a specific device type.
Fixes: #2537