Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reintroduces XCCL support for ReduceOp::PREMUL_SUM when building against oneCCL >= 2021.17 by adding version gating, reduction-op construction helpers, and RAII cleanup for custom reduction handles.
Changes:
- Add compile-time
ENABLE_XCCL_PREMUL_SUM_SUPPORTbased on oneCCL version macros. - Introduce RAII wrappers and unpack helpers to create/destroy PREMUL_SUM reduction ops for both CCL “V1” and oneCCL “V2” APIs.
- Update XCCL collective call sites to pass datatype/communicator needed to build PREMUL_SUM ops.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/xccl/xccl.h | Adds PREMUL_SUM enablement, RAII reduction wrapper, and PREMUL_SUM mapping logic in getXcclReduceOpV1/V2. |
| src/xccl/xccl.cpp | Updates allreduce/reduce/reduce_scatter wrappers to pass datatype + communicator into the reduce-op selection helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Performance outliers, please check!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reland #1948
disable_e2e
disable_ut