Explicitly skip test_out_ for histc and mean ops#3119
Open
Silv3S wants to merge 2 commits intointel:mainfrom
Open
Explicitly skip test_out_ for histc and mean ops#3119Silv3S wants to merge 2 commits intointel:mainfrom
Silv3S wants to merge 2 commits intointel:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the XPU test skip configuration to exclude two known-failing out= tests for histc and mean, aligning XPU behavior with how these cases are handled upstream on CUDA.
Changes:
- Add
test_out_histc_xpu_float32to the XPU skip list fortest_ops_xpu.py. - Add
test_out_mean_xpu_float32to the XPU skip list fortest_ops_xpu.py.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+68
to
+70
| # For CUDA it's skipped explicitly in common_methods_invocations.py in upstream. We can skip it here | ||
| "test_out_histc_xpu_float32", | ||
| "test_out_mean_xpu_float32", |
There was a problem hiding this comment.
PR description says these cases will be marked as xfails, but adding them to skip_list_common.py means they are not executed at all (the runner turns this list into pytest -k "not ..."). Either update the PR description/title to reflect that these tests are being skipped, or switch to an actual xfail mechanism if you want the tests to run but be recorded as expected failures.
2 tasks
Silv3S
added
the
disable_all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2234
Both tests are expected to fail, same as on CUDA. We can utilize
skip_list_common.pyto mark them as xfails, before the official skip incommon_methods_invocations.pyis upstreamed