align act_max of experts for qwen3-vl and qwen3-next#1311
Draft
align act_max of experts for qwen3-vl and qwen3-next#1311
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends MoE (Mixture of Experts) layer support to include Qwen3-VL and Qwen3-Next model architectures by adding their sparse MoE block identifiers to the existing detection and configuration logic.
Changes:
- Added
Qwen3NextSparseMoeBlockandQwen3VLMoeTextSparseMoeBlockto the MoE layer detection list - Updated the expert projection layer mapping to include these new block types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: He, Xin3 <[email protected]>
for more information, see https://pre-commit.ci
| "Qwen2MoeSparseMoeBlock".lower(), | ||
| "Qwen3MoeSparseMoeBlock".lower(), | ||
| "Qwen3NextSparseMoeBlock".lower(), | ||
| "Qwen3VLMoeTextSparseMoeBlock".lower(), |
Contributor
There was a problem hiding this comment.
If this change is intended to support NVFP quantization for Qwen3VLMoE&Qwen3Next, please also verify VLLM generation, thanks!
Contributor
Author
There was a problem hiding this comment.
Sure, this PR is necessary since some experts are not calibrated and act_max is missing.
yiliu30
reviewed
Jan 21, 2026
Contributor
Author
yiliu30
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.