Skip to content

[MBL-19643][Student] Show unpublished future courses in All Courses list #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hermannakos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MBL-19643][Student] Show unpublished future courses in All Courses list #3497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...cture/student/features/dashboard/edit/datasource/StudentEditDashboardNetworkDataSource.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class StudentEditDashboardNetworkDataSource(
val pastCourses = async { courseApi.firstPageCoursesByEnrollmentState("completed", params)
.depaginate { nextUrl -> courseApi.next(nextUrl, params) }.dataOrThrow }
val futureCourses = async { courseApi.firstPageCoursesByEnrollmentState("invited_or_pending", params)
.depaginate { nextUrl -> courseApi.next(nextUrl, params) }.dataOrThrow.filter { it.workflowState != Course.WorkflowState.UNPUBLISHED } }
.depaginate { nextUrl -> courseApi.next(nextUrl, params) }.dataOrThrow }

return@coroutineScope listOf(currentCourses, pastCourses, futureCourses).awaitAll()
}
Expand Down
5 changes: 3 additions & 2 deletions ...e/student/features/dashboard/edit/datasource/StudentEditDashboardNetwoekDataSourceTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class StudentEditDashboardNetworkDataSourceTest {
}

@Test
fun `Do not show unpublished future courses`() = runTest {
fun `Show unpublished future courses`() = runTest {
coEvery { courseApi.firstPageCoursesByEnrollmentState("active", any()) } returns
DataResult.Success(listOf(Course(1, name = "Course 1")))

Expand All @@ -66,10 +66,11 @@ class StudentEditDashboardNetworkDataSourceTest {

val result = dataSource.getCourses()

assertEquals(3, result.flatten().size)
assertEquals(4, result.flatten().size)
assertEquals("Course 1", result.flatten().first().name)
assertEquals("Course 2", result.flatten()[1].name)
assertEquals("Course 3", result.flatten()[2].name)
assertEquals("Course 4", result.flatten()[3].name)
}

@Test(expected = IllegalStateException::class)
Expand Down
Loading