Skip to content

Comments

SNARK-friendly STM: Support multiple Merkle Tree leaves#2866

Merged
curiecrypt merged 5 commits intomainfrom
curiecrypt/msnark/support-multiple-leaves
Dec 23, 2025
Merged

SNARK-friendly STM: Support multiple Merkle Tree leaves#2866
curiecrypt merged 5 commits intomainfrom
curiecrypt/msnark/support-multiple-leaves

Conversation

@curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Dec 17, 2025

Content

This PR includes the changes required for supporting multiple MerkleTreeLeaf types.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Comments

Issue(s)

Relates to #2795

@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Test Results

    4 files  ±0    169 suites  ±0   23m 15s ⏱️ + 1m 7s
2 280 tests ±0  2 280 ✅ ±0  0 💤 ±0  0 ❌ ±0 
7 152 runs  ±0  7 152 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9e219e2. ± Comparison against base commit b0739f5.

♻️ This comment has been updated with latest results.

@curiecrypt curiecrypt force-pushed the curiecrypt/msnark/support-multiple-leaves branch 2 times, most recently from 5c94059 to 4c07e36 Compare December 19, 2025 17:52
@curiecrypt curiecrypt marked this pull request as ready for review December 22, 2025 15:46
Copy link
Collaborator

@hjeljeli32 hjeljeli32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I only left two small suggestions around length checks in from_bytes deserialization functions, aligned what @damrobi suggested.

@curiecrypt curiecrypt force-pushed the curiecrypt/msnark/support-multiple-leaves branch from ff0b022 to 6a63eac Compare December 23, 2025 12:49
@curiecrypt curiecrypt force-pushed the curiecrypt/msnark/support-multiple-leaves branch from 6a63eac to 2559c7c Compare December 23, 2025 12:57
@curiecrypt curiecrypt force-pushed the curiecrypt/msnark/support-multiple-leaves branch from 2559c7c to 1578000 Compare December 23, 2025 14:09
@curiecrypt curiecrypt requested a review from jpraynaud December 23, 2025 14:10
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@damrobi damrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curiecrypt curiecrypt merged commit 484bb83 into main Dec 23, 2025
61 checks passed
@curiecrypt curiecrypt deleted the curiecrypt/msnark/support-multiple-leaves branch December 23, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants