feat(tx-cache): enable pagination of bundles #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supersedes #89.
prestwich
requested changes
Jan 15, 2026
Member
prestwich
left a comment
prestwich
left a comment
There was a problem hiding this comment.
is there a ticket for a followup to make a stream type?
Member
Author
|
No, we have not discussed this offline yet. This PR is only concerned with getting the bin-base client to parity with the |
Member
|
basically there should be an api like |
prestwich
reviewed
Jan 15, 2026
prestwich
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #89. Enables using pagination on the bundle-enabled tx cache client, by accepting an optional query to be passed in to the http request.