fix(common.opcua): Support byte arrays in decoding#18825
Open
wucm667 wants to merge 1 commit intoinfluxdata:masterfrom
Open
fix(common.opcua): Support byte arrays in decoding#18825wucm667 wants to merge 1 commit intoinfluxdata:masterfrom
wucm667 wants to merge 1 commit intoinfluxdata:masterfrom
Conversation
The type switch in the OPC UA input plugin was missing a case for ua.ByteArray, which is a named type (type ByteArray []byte) in the gopcua library. Go's type switch does not match named types against their underlying types, causing ByteArray values to fall through to the default error case. Add a case for ua.ByteArray that converts to []byte for proper unpacking. Fixes influxdata#18824
Contributor
|
Thanks so much for the pull request! |
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Author
|
!signed-cla |
Member
|
@wucm667 please restore the PR description template, especially the AI section! Otherwise we cannot review your contribution... |
Author
|
Done, restored the template and filled in the checklist. Thanks for the reminder! |
srebhan
changed the title
srebhan
changed the title
srebhan
added
plugin/input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When decoding OPC UA variant arrays, the plugin crashes when encountering
ua.ByteArrayvalues because the decoder does not handle this specific type. This fix adds proper handling forua.ByteArrayin the variant array decoding logic, preventing the crash.Checklist
Related issues
resolves #18824