Skip to content

feat(inputs.azure_monitor): Support secrets for client_secret#18744

Open
superguillen wants to merge 6 commits intoinfluxdata:masterfrom
superguillen:feat-azure_monitor---add-Add-Secret-support
Open

feat(inputs.azure_monitor): Support secrets for client_secret#18744
superguillen wants to merge 6 commits intoinfluxdata:masterfrom
superguillen:feat-azure_monitor---add-Add-Secret-support

Conversation

@superguillen
Copy link
Copy Markdown

@superguillen superguillen commented Apr 19, 2026 •
edited by srebhan
Loading

Summary

Checklist

Related issues

resolves #18743

@superguillen
feat(inputs.azure_monitor): add secret support for client_secret
e4e644c 
Use config.Secret for client_secret to support secret stores.
Follows pattern from mysql plugin.
@superguillen
test(inputs.azure_monitor): update tests for config.Secret
12a4136 
- Add TestInit_NoClientID and TestInit_NoTenantID tests
- Update Gather tests to resolve config.Secret before use
- Follow pattern from telegraf-private
@superguillen
fix(inputs.azure_monitor): add required field validation
a5d4f54 
Validate subscription_id, client_id, and tenant_id are not empty
before initializing the Azure client. Use errors.New for consistency
with other telegraf plugins.
@superguillen superguillen changed the title Feat azure monitor add secret support feat(inputs.azure_monitor): add secret store support for client_secret field Apr 19, 2026
@telegraf-tiger telegraf-tiger Bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 19, 2026
@srebhan srebhan changed the title feat(inputs.azure_monitor): add secret store support for client_secret field feat(inputs.azure_monitor): Support secrets for client_secret Apr 22, 2026
srebhan
srebhan reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @superguillen! Please find my comments in the code.

Comment thread plugins/inputs/azure_monitor/azure_monitor.go Outdated
Comment thread plugins/inputs/azure_monitor/azure_monitor.go Outdated
Comment thread plugins/inputs/azure_monitor/azure_monitor_test.go Outdated
@srebhan srebhan self-assigned this Apr 22, 2026
superguillen and others added 3 commits April 23, 2026 13:01
@superguillen @srebhan
Update plugins/inputs/azure_monitor/azure_monitor.go
b06b9ae 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@superguillen @srebhan
Update plugins/inputs/azure_monitor/azure_monitor.go
db931da 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@superguillen
test(azure_monitor): use Init for azure monitor gather tests
1677df4
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger Bot commented Apr 27, 2026

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB . RPM . TAR . GZ . ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @superguillen!

@srebhan srebhan added area/azure Azure plugins including eventhub_consumer, azure_storage_queue, azure_monitor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Apr 28, 2026
@srebhan srebhan assigned skartikey and unassigned srebhan Apr 28, 2026
@srebhan srebhan mentioned this pull request Apr 29, 2026
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@skartikey skartikey

Labels

area/azure Azure plugins including eventhub_consumer, azure_storage_queue, azure_monitor feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add secret support to azure_monitor

3 participants

@superguillen @srebhan @skartikey