Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 21, 2025

The prometheusremotewrite serializer outputs binary protobuf format, but the documentation example showed Prometheus text exposition format without clarifying this distinction.

Changes

  • Updated example section header to indicate the metrics shown are a logical representation, not the actual binary protobuf output format

Screenshot

Example section with clarification

The clarification prevents confusion about the serializer's actual output format while maintaining the example's usefulness for understanding the metric transformation.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update serializer documentation in Telegraf docs(telegraf): clarify prometheusremotewrite example shows logical representation Dec 21, 2025
Copilot AI requested a review from jstirnaman December 21, 2025 22:54
@jstirnaman jstirnaman marked this pull request as ready for review December 22, 2025 14:40
@jstirnaman jstirnaman merged commit 943e2af into template-serializer-docs Dec 22, 2025
1 check passed
@jstirnaman jstirnaman deleted the copilot/sub-pr-6654-again branch December 22, 2025 14:40
jstirnaman added a commit that referenced this pull request Dec 22, 2025
…epresentation (#6661)

* Initial plan

* docs(telegraf): clarify prometheusremotewrite example shows logical representation

Co-authored-by: jstirnaman <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: jstirnaman <[email protected]>
jstirnaman added a commit that referenced this pull request Dec 23, 2025
* docs(telegraf): add missing serializer documentation

Add documentation for missing output data formats (serializers):
- binary: Binary protocol serialization with configurable entries
- cloudevents: CloudEvents JSON format (v0.3 and v1.0)
- csv: Comma-separated values with configurable columns
- prometheus: Prometheus text exposition format
- prometheusremotewrite: Prometheus protobuf for remote write
- wavefront: Wavefront data format

Also fixes:
- Rename messagepack.md to msgpack.md to match Telegraf source

This completes the serializer documentation coverage.

* Apply suggestion from @jstirnaman

* Apply suggestion from @jstirnaman

* docs(telegraf): clarify prometheusremotewrite example shows logical representation (#6661)

* Initial plan

* docs(telegraf): clarify prometheusremotewrite example shows logical representation

Co-authored-by: jstirnaman <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: jstirnaman <[email protected]>

* Update content/telegraf/v1/data_formats/output/binary.md

Co-authored-by: Copilot <[email protected]>

* docs: improve prometheus serializer warnings and clarify configuration options (#6660)

* hotfix(influxdb3): fix duplicate menu entry for Enterprise security page

Change menu key from influxdb3_core to influxdb3_enterprise.

* chore(influxdb3) Security: style and cleanup: intro, requirements, callouts

* fix(influxdb3): restore clean install.md from jdstrand branch

Remove duplicate content and fix malformed code blocks introduced
during rebase conflict resolution.

* docs(telegraf): add design plan for batch format documentation

Defines documentation changes to clarify:
- Output plugin vs serializer relationship
- use_batch_format option location and purpose
- Histogram/summary handling with prometheus_client
- Choosing the right output approach

* docs(telegraf): clarify output plugins, serializers, and batch format

- Add "How output plugins use serializers" section explaining the
  relationship between output plugins and data formats
- Add "Choosing an output approach" guidance by destination and metric type
- Create prometheus serializer doc with histogram/summary guidance
- Add "Use this plugin for..." sections to prometheus_client
- Add Data formats subsection to configuration.md
- Expand output plugins index with serializer relationship

Addresses confusion about use_batch_format being an output plugin option
rather than a serializer option, and provides clear guidance on when to
use prometheus_client vs the prometheus serializer.

---------

Co-authored-by: Jason Stirnaman <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants