Skip to content

chore: update go to 1.25.7#6181

Open
karel-rehor wants to merge 11 commits intomasterfrom
chore/upgrade-go-1.25.7
Open

chore: update go to 1.25.7#6181
karel-rehor wants to merge 11 commits intomasterfrom
chore/upgrade-go-1.25.7

Conversation

@karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Feb 26, 2026

Updates reference go to 1.25.7

Modifies darwin builds to enforce dynamic builds only.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • swagger.json updated (if modified Go structs or API) N.A.
  • Sign CLA (if not already signed)

@karel-rehor karel-rehor marked this pull request as ready for review February 26, 2026 16:17
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update boto python package to boto3. You can use same changes as is in Kapacitor: influxdata/kapacitor#2882

@karel-rehor karel-rehor requested a review from bednar March 3, 2026 09:15
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update build.py to produce the darwin_arm64 platform. That was the main reason for updating the cross-builder: https://influxdata.slack.com/archives/C5BSZ026L/p1771865808540019?thread_ts=1771519610.383949&cid=C5BSZ026L

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increate timeout for deploy command in CircleCI as is here: influxdata/kapacitor#2883

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@karel-rehor karel-rehor requested a review from bednar March 5, 2026 15:23
@karel-rehor
Copy link
Contributor Author

@bednar

I've needed to make some additional changes to ensure that darwin arm64 can actually build properly. These changes are in the scripts ./etc/scripts/install-deps.sh and in build.py.

The packages installed and the configuration values provided might be better added to the cross-builder. These changes are a bit different from what was discussed offline, so maybe a change to cross-builder will not be required but would be nice to have.

As discussed the go flux module is temporarily set to use yesterday's commit. Waiting on a response from the flux team regarding a release. Merging should be blocked until this is resolved.


// N.B. this is for testing the build, if this works - need to request a minor release of this library
replace github.com/influxdata/flux => github.com/influxdata/flux v0.199.1-0.20260304200511-f33aac92ccdc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above needs to be set to an actual release, when available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants