Skip to content

Dygraph Fork for Milliseconds#2127

Merged
cryptoquick merged 3 commits intomasterfrom
feature/milliseconds
Oct 17, 2017
Merged

Dygraph Fork for Milliseconds#2127
cryptoquick merged 3 commits intomasterfrom
feature/milliseconds

Conversation

@cryptoquick
Copy link
Contributor

@cryptoquick cryptoquick commented Oct 17, 2017

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #1449

The problem

Chronograf graphs in UI wouldn't label millisecond or sub-millisecond axes.

The Solution

Fork Dygraphs to our own company GItHub account and apply changes from danvk/dygraphs#777, and then point our project use that repository.

CHANGELOG.md Outdated
### Features
1. [#2083](https://github.com/influxdata/chronograf/pull/2083): Every dashboard can now have its own time range
1. [#2045](https://github.com/influxdata/chronograf/pull/2045): Add CSV download option in dashboard cells
1. [#2127](https://github.com/influxdata/chronograf/pull/2127): Add CSV download option in dashboard cells
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the changelog editing stomped other changes?

@121watts
Copy link
Contributor

121watts commented Oct 17, 2017

This does the thing! These points are all over the 39th second:

kapture 2017-10-17 at 14 12 46

Copy link
Contributor

@121watts 121watts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled it down and tested it out. LGTM 😄

@cryptoquick cryptoquick merged commit afeda3b into master Oct 17, 2017
@cryptoquick cryptoquick deleted the feature/milliseconds branch October 17, 2017 22:18
### UI Improvements
1. [#2111](https://github.com/influxdata/chronograf/pull/2111): Increase size of Cell Editor query tabs to reveal more of their query strings
1. [#2119](https://github.com/influxdata/chronograf/pull/2119): Add cancel button to Tickscript editor
1. [#2119](https://github.com/influxdata/chronograf/pull/2119): Add support for graph zooming and point display on the millisecond-level
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this clobbered the changelog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, Chris. Fixing in master.

@nhaugo
Copy link
Contributor

nhaugo commented Oct 18, 2017

@cryptoquick couple of issues, when you zoom in and you don't select a full set of data the graph shows no results (which it shouldn't). Also when you get into this state you can no switch time range via the drop down, e.g. try to switch it to past 15 min.

sadzoom

@cryptoquick
Copy link
Contributor Author

@nhaugo I can only replicate this if I'm using the date picker. If I use 'fixed' query like this in a cell, I can't replicate it:
SELECT mean("value") AS "mean_value" FROM "telegraf"."autogen"."foo" WHERE time > '2017-10-09T20:44:39.000Z' AND time < '2017-10-09T20:44:40.000Z' GROUP BY time(1ms)
It might have something to do with template variables, but I'm not sure. TBH, I'm not sure I'm a fan of not rendering the graph when there are no results. I would actually prefer to use Dygraph to render text on the canvas, so you don't actually take away all of Dygraph's functionality when the dataset empty, and to render empty data sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants