Implement merge_prop_transformer configuration - #267
Closed
pedrofs wants to merge 3 commits into
Closed
Conversation
Collaborator
|
We've talked about this and decided that the JS side is the better place to do key transformation. That way we avoid having to worry about transforming the keys that come back to the server from the React app @skryukov built an NPM packages that handles converting to camelCase for Inertia apps that does this all very cleanly: https://github.com/skryukov/inertia-caseshift We'd recommend using that instead of transforming props in Rails. We're going to deprecate the Inertia Rails prop transformation feature (instead of improving it) and eventually remove it. That said, thanks for submitting the PR and sorry for this sitting around for so long! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using the
prop_transformerto maintain a clear naming convention between React and Rails: React is camelCase and Rails is snake_case.Unfortunately, I faced an inconsistency when trying to work with the InertiaRails.merge functionality. See #266 .
This PR introduces the
merge_prop_transformerconfiguration, similar to theprop_transformer. It'll receive the array of merge keys, and you can transform them as you wish.