Skip to content

HTP-0002 Conversant: Fix duplicate imp.ids on the conversant adapter #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnwier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HTP-0002 Conversant: Fix duplicate imp.ids on the conversant adapter #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 15 additions & 27 deletions conversant/conversant-htb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,25 +125,28 @@ function ConversantHtb(configs) {
*/

function __getImps(returnParcels) {
var conversantImps = [];
var secure = Browser.getProtocol()
.search(/^https:/i) >= 0 ? 1 : 0;

// Each parcel is a unique combination of a htSlot and xSlot.
// Since Conversant bid requests do not require unique placement ids,
// RequestIds are used instead.
// Generate a new id and save it to be matched up in the response

for (var i = 0; i < returnParcels.length; ++i) {
var parcel = returnParcels[i];
return returnParcels.map(function (parcel) {
var xSlot = parcel.xSlotRef;
var imp = {};
var banner = {};

imp.id = parcel.requestId;
imp.id = System.generateUniqueId();
xSlot.id = imp.id;
imp.secure = secure;
imp.displaymanager = '40834-index-client';
imp.displaymanagerver = __profile.version;

imp.banner = {};
imp.banner.format = xSlot.sizes.map(function (size) {
return {
w: size[0],
h: size[1]
};
});
if (xSlot.hasOwnProperty('bidfloor')) {
imp.bidfloor = xSlot.bidfloor;
}
Expand All @@ -152,27 +155,12 @@ function ConversantHtb(configs) {
imp.tagid = xSlot.placementId;
}

var format = [];
for (var sizeIdx = 0; sizeIdx < xSlot.sizes.length; ++sizeIdx) {
var size = xSlot.sizes[sizeIdx];
format.push({
w: size[0],
h: size[1]
});
}

banner.format = format;

if (xSlot.hasOwnProperty('position')) {
banner.pos = xSlot.position;
imp.banner.pos = xSlot.position;
}

imp.banner = banner;

conversantImps.push(imp);
}

return conversantImps;
return imp;
});
}

/**
Expand Down Expand Up @@ -441,7 +429,7 @@ function ConversantHtb(configs) {
*/

/* -------- Fill this out to find a matching bid for the current parcel --------- */
if (curReturnParcel.requestId === bids[i].impid) {
if (curReturnParcel.xSlotRef.id === bids[i].impid) {
curBid = bids[i];
bids.splice(i, 1);

Expand Down