helium/ui: add MRU tab cycling popup behind experimental flag#1376
helium/ui: add MRU tab cycling popup behind experimental flag#1376markwai wants to merge 1 commit into
Conversation
|
Reviews (1): Last reviewed commit: "helium/ui: add MRU tab cycling popup beh..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
markwai
force-pushed
the
tab-cycling-popup
branch
from
2acbcef to
fa30b2c
Compare
|
@markwai thank you for opening this PR, this feature is really needed, IMO. i noticed that the CI is failing and there are two unresolved (?) issues from greptile. just wanted to ping you about this so this can ideally be implemented soon... |
markwai
force-pushed
the
tab-cycling-popup
branch
from
fa30b2c to
dc1e1a2
Compare
|
imho musthave |
markwai
force-pushed
the
tab-cycling-popup
branch
from
dc1e1a2 to
9accd99
Compare
|
excited about this feature! |
|
Pls resolve conflicts and let's merge |
markwai
force-pushed
the
tab-cycling-popup
branch
3 times, most recently
from
049d3f4 to
5bf3647
Compare
|
Any updates on this? |
|
bumped to version 148 and updated line references, tested on my mac, checks passed |
|
Can you take this further and add thumbnails in a grid like Dia and Arc? I feel like that's the standard at this point. However, this should absolutely be a thing. |
markwai
force-pushed
the
tab-cycling-popup
branch
from
3d24485 to
c539d7c
Compare
Add a centered popup overlay for MRU tab cycling, gated behind the --helium-tab-cycling-popup chrome://flags entry (disabled by default). When the flag is enabled and Ctrl+Tab is pressed with MRU cycling active, a popup lists tabs in most-recently-used order. The highlight moves with each Tab press and activation is deferred until Ctrl is released. When the flag is disabled, tab cycling behaves as before with immediate activation on each step.
markwai
force-pushed
the
tab-cycling-popup
branch
from
c539d7c to
32740a5
Compare
|
hey super interested in this as well |
|
Here's a demo video of how Dia's works and looks: https://dropover.cloud/3b8541. The keyboard shortcuts are:
|
|
Here's an image of it: It's way quicker to spot the tab you want to go to via the thumbnail that it is with just text. That becomes very apparent when you have multiple tabs open of the same site. |
6 participants
For your pull request to not get closed without review, please confirm that:
(an approved feature request, or confirmed bug).
otherwise I have marked my PR as draft.
organization if I lied by checking any of these checkboxes.
Tested on (check one or more):
Related to issue #238 (I put my changes behind a flag). Basically I've added a pop up when cycling MRU tabs. So the active tab does not switch until a selection is made from the popup (the keyboard shortcut is withheld). No mouse integration (mousover and click do not affect the popup). Currently I put this behind experiment flag #helium-tab-cycling-popup, ran tests and had to do some fixes to pass cirrus. Example of it working locally here:
tab-cycling-popup.mp4