Skip to content

Discord embed now has a black stripe for cobalt.tools#738

Open
SpiritAxolotl wants to merge 2 commits intoimputnet:mainfrom
SpiritAxolotl:main
Open

Discord embed now has a black stripe for cobalt.tools#738
SpiritAxolotl wants to merge 2 commits intoimputnet:mainfrom
SpiritAxolotl:main

Conversation

@SpiritAxolotl
Copy link
Copy Markdown

Simple one-line change that makes the little stripe on cobalt embeds black instead of the default.
image

@SpiritAxolotl
Copy link
Copy Markdown
Author

@dumbmoron can you approve this perchance

@wukko
Copy link
Copy Markdown
Member

wukko commented Sep 14, 2024

does this affect the experience of page loading in browsers that use the accent color? i’d imagine the color would flicker on android in chrome, but i may be wrong

@SpiritAxolotl
Copy link
Copy Markdown
Author

SpiritAxolotl commented Sep 14, 2024

more information on the tag property: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name/theme-color

it also seems like you can use the media property to make dark/light mode versions and I could just change that with js if the user overrides it? that would require more work on my part to do that. should I change the pr to a draft?

@lostdusty
Copy link
Copy Markdown
Contributor

this should be closed since this is already a thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants