frontend/newtab: fix replacing popup with small inline message#1526
Open
jackoluciano wants to merge 1 commit intoimputnet:mainfrom
Open
frontend/newtab: fix replacing popup with small inline message#1526jackoluciano wants to merge 1 commit intoimputnet:mainfrom
jackoluciano wants to merge 1 commit intoimputnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, the window.open() function is not reliable in determining whether a new tab was successfully opened. in many browsers, it returns null due to security restrictions (noreferrer deletes any communication line to the original tab). this leads to situations where the media is successfully opened yet the error popup is still shown, which is unnecessary and annoying
a solution that works better is to change the popup into an inline message stating: "if nothing opened, click here to open it manually."
as a result, i removed the blocked message dialog completely along with the popup block, and introduced a new dialog that needs to be translated into other languages by the community