Conversation
glaubersilva
left a comment
There was a problem hiding this comment.
@jonwaldstein Great work! It's working well to create one-time donations. However, I noticed a few things we need to fix on the codebase and left a few comments about them, and I also noticed an inconsistency with the currency setup.
I did set up the Ghana cedi (₵) currency on the GiveWP settings. So, I can see in V2 forms values like this ₵ 100 in the form levels and goals. However, for V3 forms, it's displayed like GHS 100 instead. In the WP admin area, all donations are displayed in GHS.
src/Paystack/Gateway/DataTransferObjects/InitializeTransactionResponse.php
Outdated
Show resolved
Hide resolved
src/Paystack/Gateway/DataTransferObjects/InitializeTransactionResponse.php
Show resolved
Hide resolved
|
@glaubersilva thanks for the review! all comments have been addressed and ready for re-review 🪇 |
|
@jonwaldstein I'm still seeing the |
|
@glaubersilva Ah yeah, that's because v3 forms uses the browser to format the currency and v2 forms uses the currency symbol defined in the server's currency list. I'm honestly okay with v2 looking different as currency formatting is handled differently between the forms. The good news is people can easily modify those symbols through the filter if need be. |
glaubersilva
left a comment
There was a problem hiding this comment.
@jonwaldstein Thanks for the clarification and great work! This is ready to QA! 🚀
Resolves GIVE-2684
Description
Introducing Give Paystack version 3.0!
This plugin has been completely updated to support the latest version of GiveWP (4.0+). This means the plugin can now be used with campaigns, option-based forms and the visual form builder. Later we can also introduce recurring donations via the Gateway API.
In order to preserve backwards compatibility, the following has remained the same:
For existing customers, they will really just get the benefit of this plugin working again as it's been abandoned for quite some time and not up to date with GiveWP.
Affects
The affects the entire plugin 😏
Visuals
https://www.loom.com/share/f34327884748459cb5e453fc55d46e4e?sid=155d86bd-87a0-4780-9a41-d580f0f7d916
Testing Instructions
ZIP: https://github.com/impress-org/give-paystack-gateway/actions/runs/17646529453
First you'll need a Paystack account
Test with GiveWP
Test updating to this version
Pre-review Checklist
@unreleasedtags included in DocBlocks