refactor: avoid reordering attributes when restoring them#1433
Merged
fw-immunant merged 2 commits intomasterfrom Feb 20, 2026
Merged
refactor: avoid reordering attributes when restoring them#1433fw-immunant merged 2 commits intomasterfrom
fw-immunant merged 2 commits intomasterfrom
Conversation
Contributor
Author
|
I added a test but I'm not sure that these c2rust-refactor tests are actually run in CI. It seems like we're not running |
ahomescu
requested changes
Oct 28, 2025
kkysen
reviewed
Oct 28, 2025
fw-immunant
force-pushed
the
fw/refactor-derives
branch
from
9a2ef27 to
1251c6c
Compare
kkysen
reviewed
Dec 8, 2025
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
Is this why stuff like #[c2rust::src_loc = "125:8"]#[derive(Copy, Clone)] is happening? I noticed that while testing crisp.
Contributor
Author
Yeah, this PR fixes that weird formatting. |
Contributor
|
We should land this. |
ahomescu
approved these changes
Feb 20, 2026
fw-immunant
force-pushed
the
fw/refactor-derives
branch
from
1251c6c to
11ba291
Compare
fw-immunant
changed the base branch from
master
to
kkysen/refactor-snapshot-tests-named
kkysen
reviewed
Feb 20, 2026
fw-immunant
force-pushed
the
fw/refactor-derives
branch
from
11ba291 to
65bcebf
Compare
fw-immunant
force-pushed
the
fw/refactor-derives
branch
from
65bcebf to
35492ca
Compare
Base automatically changed from
kkysen/refactor-snapshot-tests-named
to
master
February 20, 2026 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
including in the presence of multiple
#[derive(...)]attributes interleaved with other attributes. No test at present; I'll look into adding one.