Conversation
kkysen
force-pushed
the
kkysen/ci-arm64-linux
branch
from
14af033 to
920543f
Compare
Contributor
|
Note to see if we can enable varargs tests on aarch64 Linux when this lands. |
Contributor
|
It looks to me like this is a toolchain problem. Probably using a stable toolchain where possible would help, as suggested in #1227. |
Contributor
Author
That should fix compiling the transpiler, but not the rest of the codebase where the errors are from. |
fw-immunant
force-pushed
the
kkysen/ci-arm64-linux
branch
from
920543f to
0f9cdf0
Compare
kkysen
added a commit
that referenced
this pull request
Dec 7, 2025
* Fixes #1353. This reworks the implementation of `is_va_list`, so that it is more accurate (less false positives/negatives). It's split into two subfunctions, one that detects `va_list` based on the `__builtin_va_list` typedef, and the other that detects based on the architecture-specific struct definition. Both methods have situations in which they don't work, so they are used together. This has been confirmed to work on: - Linux x86-64 - Linux x86-32 (was previously broken) MacOS aarch64 is still failing if I enable it, because things like `va_start` seem to be unimplemented. Testing for Linux aarch64 will depend on #1283.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just testing.