fix(server): store null instead of empty string for person thumbnailPath - #30070
Open
deveshkolte wants to merge 2 commits into
Open
fix(server): store null instead of empty string for person thumbnailPath#30070deveshkolte wants to merge 2 commits into
deveshkolte wants to merge 2 commits into
Conversation
|
Label error. Requires exactly 1 of: changelog:.*. Found: 🗄️server. A maintainer will add the required label. |
Member
|
You'll have to run |
11 tasks
timonrieger
requested changes
Jul 25, 2026
timonrieger
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for picking this up! A few things before this can go in:
- critical: thumbnail generation queues people via
getAll({ thumbnailPath: '' }). with new persons defaulting tonullthat never matches, so person thumbnails silently stop being generated. update the query tonull - strip the session
deviceType/deviceOSchanges, that's #30048's scope (one column per PR) - add
dbtodown()as a param - Still missing from the pinned post in #28832: keep returning
''on responses with a v4 TODO,HistoryBuilderon the response fields, regenerated OpenAPI spec/SDKs.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a person is created without a thumbnail (before the thumbnail job runs),
the database now stores
NULLinstead of an empty string"".Changes:
Fixes #28832 (person.thumbnailPath column)
How Has This Been Tested?
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
None. I manually wrote the code following the established pattern from a previously merged PR for the same issue.