fix(web): correctly display asset dates in historical timezones - #30033
Open
compscitwilight wants to merge 5 commits into
Open
fix(web): correctly display asset dates in historical timezones#30033compscitwilight wants to merge 5 commits into
compscitwilight wants to merge 5 commits into
Conversation
|
Label error. Requires exactly 1 of: changelog:.*. Found: 🖥️web. A maintainer will add the required label. |
Member
|
I am unsure if this even fixes anything, or if this has already been resolved in v3. Let's wait until we get confirmation on the issue before considering this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where editing and displaying asset dates in timezones with historical offset changes could result in an incorrect local time being shown in the web UI.
Additionally, I've addressed a subtle UI desync issue when editing datetime values for assets. When you edit an asset's timestamp via the modal, it will now reflect the same changed value inside of the detail panel as well.
Fixes #29364
How Has This Been Tested?
America/Indiana/VincennesScreenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
Used an LLM to assist with understanding the existing date handling code and investigating the interaction between timezone conversions and Svelte code. I performed the implementation and code changes myself.