Avoid subtract overflow in filter3x3 on zero-dimension images#3073
Closed
SAY-5 wants to merge 1 commit into
Closed
Avoid subtract overflow in filter3x3 on zero-dimension images#3073SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Member
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filter3x3reads its dimensions and then loops1..width - 1/1..height - 1. On an image with zero width or height those subtractions underflow and panic with "attempt to subtract with overflow" (reported in #3026).Such an image has no interior pixels to filter, so this returns the empty output buffer early, matching how
resizealready handles the empty case. Added a regression test covering both zero-width and zero-height inputs.Fixes #3026.