perf: Neon Paeth unfiltering (3bpp)#638
Draft
Sentimentron wants to merge 1 commit intoimage-rs:masterfrom
Draft
Conversation
Contributor
Author
|
Results on Apple Silicon: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a counter-point to #632, this PR ports over the Neon code from libpng
Theoretical results from the micro-architecture simulator indicate an improvement in cycles (n.b. that cache hierarchy is not modelled):
Results from a Pixel 10:
This is not really intended to merge, but offers another data point for
portable_simd: some of the gain, but less than what's possible with per-architecture intrinsics.