Skip to content

Refactor py_lint for parallel execution and DRY shell config (v4)#45

Open
iloveitaly wants to merge 1 commit intomasterfrom
parallel-py-lint-13639128692039809176
Open

Refactor py_lint for parallel execution and DRY shell config (v4)#45
iloveitaly wants to merge 1 commit intomasterfrom
parallel-py-lint-13639128692039809176

Conversation

@iloveitaly
Copy link
Owner

Refactor py_lint for parallel execution and DRY shell config (v4).

  • Parallelization: Run linting tasks (ruff, pyright, shadowed, j2lint, djlint) concurrently using just's [parallel] attribute for improved performance.
  • DRY Shell Config: Consolidate shell verbosity configuration (setopt prompt_subst, export PS4, set -x) into CONFIGURE_SHELL variable.
  • Documentation: Added clear comment explaining PS4 usage.
  • Restoration: Restored important comments about +FILES argument usage that were inadvertently removed.
  • Fixes: Correctly interpolates FILES arguments in sub-recipes.

PR created automatically by Jules for task 13639128692039809176 started by @iloveitaly

- Split `py_lint` into 5 parallel sub-recipes (`_py_lint_ruff`, `_py_lint_pyright`, etc.) in `just/python.just`.
- Introduced `CONFIGURE_SHELL` variable to centralize shell verbosity settings (PS4, set -x).
- Applied `CONFIGURE_SHELL` to `py_test` and new lint recipes to remove code duplication.
- Added explanatory comment for `PS4` shell configuration.
- Restored original comments regarding `+FILES` argument usage in `py_lint`.
- Maintained existing CI/local logic and output formats.

Co-authored-by: iloveitaly <150855+iloveitaly@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments