fix: wsl disable-gpu for tests, add is_wsl environment#43
Merged
iloveitaly merged 1 commit intoiloveitaly:masterfrom Feb 19, 2026
Merged
fix: wsl disable-gpu for tests, add is_wsl environment#43iloveitaly merged 1 commit intoiloveitaly:masterfrom
iloveitaly merged 1 commit intoiloveitaly:masterfrom
Conversation
iloveitaly
reviewed
Feb 19, 2026
|
|
||
| # Auto-disable GPU if we detect we are inside WSL | ||
| # As GPU acceleration in WSL can be unstable and cause test failures, | ||
| # we disable it for better stability. |
Owner
There was a problem hiding this comment.
very nit: # we disable it for better stability. this is self-evident, we could have kept this comment shorter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Enabled GPU for playwright, makes some of integration tests unstable, and thus failing randomly
Description
--disable-gpuflag if running playwright tests on wslis_wslfunction inenvironments.py