Skip to content

Add PID and worker ID to Celery logs#42

Open
iloveitaly wants to merge 1 commit intomasterfrom
celery-worker-logging-enrichment-8655463301281973614
Open

Add PID and worker ID to Celery logs#42
iloveitaly wants to merge 1 commit intomasterfrom
celery-worker-logging-enrichment-8655463301281973614

Conversation

@iloveitaly
Copy link
Owner

This PR enriches Celery logs with the current process ID and worker name (e.g., ForkPoolWorker-8).

Changes:

  • Added a helper function _bind_worker_process_context in app/celery.py that binds pid and worker_id to the structlog context.
  • Hooked this helper into worker_process_init to initialize the context for new worker processes.
  • Updated on_task_prerun and on_task_postrun to re-bind this context because the existing log.clear() calls wipe out the worker-level context.

Verification:

  • Manual verification of the logic was performed using a mock log script.
  • Full test suite could not be run due to local Python version mismatch (3.14 required), but ruff was used for static analysis and passed.

PR created automatically by Jules for task 8655463301281973614 started by @iloveitaly

- Import os and multiprocessing in app/celery.py
- Add _bind_worker_process_context helper to set pid and worker_id in structlog
- Update worker_process_init to bind process context
- Update task_prerun and task_postrun to re-bind process context after log.clear()
- Resolves TODO in app/celery.py and improves debuggability of worker logs.

Co-authored-by: iloveitaly <150855+iloveitaly@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments