Clarify CastsAttributes::set() phpdoc to accept TGet; recommend symmetric casts#10
Open
andreas-pms wants to merge 1 commit into
Open
Clarify CastsAttributes::set() phpdoc to accept TGet; recommend symmetric casts#10andreas-pms wants to merge 1 commit into
CastsAttributes::set() phpdoc to accept TGet; recommend symmetric casts#10andreas-pms wants to merge 1 commit into
Conversation
… symmetric casts - PhpDoc: explain assignment symmetry; set() can receive runtime value (TGet) - Change @param to TGet|TSet|null - Note on object caching; encourage symmetric casts (TGet == TSet) - No runtime behavior changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a custom cast returns an object in
get(), Eloquent may later pass that same runtime value intoset()(e.g. after reading and re-assigning). Without acknowledging this, casts that accept only “assignment types” (TSet) can fail in common flows like:This is fundamentally about assignment symmetry: developers reasonably expect
$a = $a = $bto be safe.Rationale
set()can receive the runtime value produced byget().No runtime behavior changes; this is a phpdoc clarification that improves developer expectations and static analysis.