HostedRoom: throw error on parsing room JID instead of checking for a null#696
Open
stokito wants to merge 1 commit intoigniterealtime:masterfrom
Open
HostedRoom: throw error on parsing room JID instead of checking for a null#696stokito wants to merge 1 commit intoigniterealtime:masterfrom
stokito wants to merge 1 commit intoigniterealtime:masterfrom
Conversation
… null Signed-off-by: Sergey Ponomarev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was hard to debug which room exactly caused and exception because the error message was only about null value. Using the
.asEntityBareJidOrThrow()will also have the room JID in the error message.Part of the declined #694