Conversation
smack-core/src/main/java/org/jivesoftware/smack/packet/MessageBuilder.java
Show resolved
Hide resolved
Flowdalic
left a comment
There was a problem hiding this comment.
I don't see the point in switching to String concatenation over StringBuilder. Yes, javac will probably transform String concatenation to StringBuilder and yes, one could argue it's slightly more readable. But am I not convinced that it's worth to change.
In general, please make sure that you don't conflate multiple changes within the same commit (or even, within the same PR). This makes it easier to review stuff, keeps the history clean and increases the chances for undisputed changes to land.
smack-core/src/test/java/org/jivesoftware/smack/packet/MessageTest.java
Outdated
Show resolved
Hide resolved
smack-core/src/test/java/org/jivesoftware/smack/packet/MessageTest.java
Outdated
Show resolved
Hide resolved
smack-core/src/test/java/org/jivesoftware/smack/packet/MessageTest.java
Outdated
Show resolved
Hide resolved
The javac will use concatenation with |
|
I am still skeptical that switching from |
9a8a97e to
ff709e1
Compare
|
I removed the commit with he StringBuilder |
There is still an unrelated change in the commit |
Signed-off-by: Sergey Ponomarev <[email protected]>
… to https://xmpp.org/extensions/xep-XXXX.html Signed-off-by: Sergey Ponomarev <[email protected]>
ff709e1 to
5c2a35f
Compare
|
I fixed your comments. Also I noticed that some links to XEPs are outdated with JEP-XXXX.html. Others use |
Also cleanup MessageTest