Skip to content

Make the acoustics simulation modular#125

Merged
sergioburdisso merged 3 commits intoidiap:mainfrom
qanastek:main
Mar 17, 2026
Merged

Make the acoustics simulation modular#125
sergioburdisso merged 3 commits intoidiap:mainfrom
qanastek:main

Conversation

@qanastek
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 48.21429% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.79%. Comparing base (54d8ec8) to head (7e8b001).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/sdialog/audio/pipeline.py 18.75% 13 Missing ⚠️
.../sdialog/audio/room_acoustics_backends/resolver.py 28.57% 10 Missing ⚠️
...g/audio/room_acoustics_backends/pyroomacoustics.py 57.14% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   50.76%   50.79%   +0.02%     
==========================================
  Files          44       48       +4     
  Lines        7365     7410      +45     
==========================================
+ Hits         3739     3764      +25     
- Misses       3626     3646      +20     
Files with missing lines Coverage Δ
.../sdialog/audio/room_acoustics_backends/__init__.py 100.00% <100.00%> (ø)
src/sdialog/audio/room_acoustics_backends/base.py 100.00% <100.00%> (ø)
...g/audio/room_acoustics_backends/pyroomacoustics.py 57.14% <57.14%> (ø)
.../sdialog/audio/room_acoustics_backends/resolver.py 28.57% <28.57%> (ø)
src/sdialog/audio/pipeline.py 33.18% <18.75%> (-0.31%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergioburdisso sergioburdisso merged commit c1ff862 into idiap:main Mar 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants