feat: cleanup context behavior change#71
Draft
idebeijer wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Igor de Beijer <71566757+idebeijer@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Removes the transitional in-place context switch warning (introduced for v0.8.0 behavior change) along with its persisted counter state and associated tests.
Changes:
- Drops
InPlaceSwitchWarnCount/RecordInPlaceSwitchWarnand theInPlaceSwitchWarnMaxconstant from the state package. - Removes the warning block emitted from
switchContextInPlaceincmd/context.goand the unusedfatih/colorimport there. - Deletes corresponding tests (
warnings_test.goandTestContextOptions_Run_WarningSuppressedAfterMax).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/state/warnings.go | Deleted file containing the warning counter accessors. |
| internal/state/warnings_test.go | Deleted tests for the removed counter. |
| internal/state/state.go | Drops the InPlaceSwitchWarnCount field from persisted State. |
| cmd/context.go | Removes warning emission and now-unused color import. |
| cmd/context_test.go | Removes the test exercising the warning suppression behavior. |
Note: Removing the InPlaceSwitchWarnCount JSON field is backward-compatible for unmarshaling (existing state files with the field will simply ignore it), so no migration is required.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Igor de Beijer <71566757+idebeijer@users.noreply.github.com>
Signed-off-by: Igor de Beijer <71566757+idebeijer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.