RBMC: Add PeerConnected to rbmctool output#145
Merged
spinler merged 2 commits intoibm-openbmc:1210from Apr 22, 2026
Merged
Conversation
Since the RBMC code uses PeerConnected to enable redundancy, and will wait on it to change to connected, display the value in the rbmctool output. Only display it if it isn't Connected, as normal operation is for it to be connected assuming the sibling BMC is present. Tested: ``` Local BMC ----------------------------- ... Provisioned: true Peer Connected: NotConnected <----- Role Reason: Failover ``` Change-Id: Ibe8d992e460af80901b34b68b22a21c8694fbcca Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Use the real 'provisioned' value from the provisioning service for that rbmctool field. Also, only display it if it is false, since that is the interesting value, and after the system is initially paired the value won't change again (until a factory reset). Finally, change the field name from 'Provisioned' to 'Paired' since that is the correct term. Tested: - When not paired, value is seen: ... Paired: false Peer Connected: NotConnected ... - When paired, value goes away Change-Id: I2310cbc68db7c04bd9c7368128eab9c3c8e3677b Signed-off-by: Matt Spinler <spinler@us.ibm.com>
RameshIyyar
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the RBMC code uses PeerConnected to enable redundancy, and will wait on it to change to connected, display the value in the rbmctool output.
Only display it if it isn't Connected, as normal operation is for it to be connected assuming the sibling BMC is present.
Also read the real value for the provisioned property, and only display that when it is false. Change the field name to 'Paired' since that is the correct name.