Skip to content

Fix ILU destroy issues in UVM GPU mode - #1588

Open
victorapm wants to merge 2 commits into
masterfrom
ilu-uvm-fixes
Open

Fix ILU destroy issues in UVM GPU mode#1588
victorapm wants to merge 2 commits into
masterfrom
ilu-uvm-fixes

Conversation

@victorapm

@victorapm victorapm commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Extends fixes proposed in #1585 to remaining ILU types.

Fixes ILU teardown crashes caused by factor matrices being tagged with the handle default memory location while their arrays lived at A’s location (often HOST after host assemble + device default switch).

Instead of retagging via hypre_CSRMatrixMemoryLocation(...) = ..., initialize factors/work vectors with the intended location via initialize_v2 APIs.

Closes #1569
Closes #1336

mrowan137 and others added 2 commits July 21, 2026 21:17
@mrowan137
Tag ILU(0) factor matrices with A's memory location to fix teardown (#…
8f52953 
…1585)

This proposed fix is similar to #1111 for ILUT; tag factor matrices with A's memory location, ensuring hipFree isn't called on host memory.

Co-authored-by: mrowan137 <mrowan137@users.noreply.github.com>
@victorapm
Extend ILU fixes
99789a1
@victorapm victorapm added the Run CI Label to trigger CI jobs label Jul 22, 2026
rfalgout
rfalgout approved these changes Jul 22, 2026
View reviewed changes

@rfalgout rfalgout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@victorapm victorapm mentioned this pull request Jul 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rfalgout rfalgout rfalgout approved these changes
@oseikuffuor1 oseikuffuor1 Awaiting requested review from oseikuffuor1

Assignees

No one assigned

Labels

Run CI Label to trigger CI jobs

Projects

None yet

Milestone

No milestone

3 participants

@victorapm @rfalgout @mrowan137