Conversation
victorapm
marked this pull request as ready for review
July 22, 2026 13:59
victorapm
requested review from
liruipeng,
oseikuffuor1,
rfalgout and
waynemitchell
July 22, 2026 13:59
victorapm
changed the title
waynemitchell
approved these changes
Jul 28, 2026
waynemitchell
left a comment
waynemitchell
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me. I did not check the details, since there is a lot of rocsparse/cusparse specific stuff here that I am not familiar with. Thanks for all the work, Victor!
rfalgout
approved these changes
Jul 28, 2026
rfalgout
left a comment
rfalgout
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me, @victorapm . How much testing have you done wrt portability and performance? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates our rocSPARSE SpMV usage by using the modern APIs in rocSPARSE
We are also adding the (global) option of switching the SpMV algorithm type in use.
TODO:
cc @YvanMokwinski @amontoison @kliegeois @kswirydo