This repository was archived by the owner on Feb 1, 2024. It is now read-only.
Update sawtooth-default-poet.yaml#2434
Open
bmoore06 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Benjamin Moore <[email protected]>
scealiontach
reviewed
Mar 1, 2023
There was a problem hiding this comment.
These are mostly just formatting/style changes. I'd suggest that if we are going to update it then we should make it significantly easier to read and manage. What we've got now is a gnarly mess of escaping and quotes. We could improve it by changing the commands to follow a form along the lines of
service-0:
entrypoint:
- bash
- -ec
command: |
echo "Now we don't need to escape or use && as much";
tail -f /dev/null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Moore [email protected]