feat(dfir_lang, hydro_lang): Keyed ops #2570
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Not sure why ubuntu is failing |
Member
|
Look like a flake, re-running now. |
shadaj
requested changes
Feb 11, 2026
| #context.state_ref_unchecked(#counterdata_ident) | ||
| }.borrow_mut(); | ||
|
|
||
| let counter = map.entry(::std::clone::Clone::clone(&k)) |
Member
There was a problem hiding this comment.
This incurs an unnecessary Clone, should not require that.
Member
There was a problem hiding this comment.
On second thought. You'll need Clone but this can be optimized to only clone if the key is not already in the map. This means you'll also need to add the where K: Clone clause on the corresponding Hydro API.
| /// # })); | ||
| /// # } | ||
| /// ``` | ||
| pub fn enumerate(self) -> KeyedStream<K, (usize, V), L, B, TotalOrder, ExactlyOnce> { |
Member
There was a problem hiding this comment.
This should only be available on TotalOrder streams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enumerate_keyed, sort_keyed, unique_keyed