Skip to content

robot.Start(): logging and return the error is bad practice #1183

Description

@gen2thomas

The caller should decide how to handle the returned error. In most cases the caller will log the error and exit, but it is also possible to just log a common error and retry. Another possibility is to write the output to a dedicated file, not to STDOUT. The current implementation results at least to duplicate logging.

A good summary of the topic can be found here: Handle Errors Once.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions