Skip to content

Develop jdi interpolate middleware account#927

Open
hxtree wants to merge 11 commits intomainfrom
develop-jdi-interpolate-middleware-account
Open

Develop jdi interpolate middleware account#927
hxtree wants to merge 11 commits intomainfrom
develop-jdi-interpolate-middleware-account

Conversation

@hxtree
Copy link
Owner

@hxtree hxtree commented Dec 19, 2025

Changes
CDK Destroy Force Flag
Added --force flag to the cdk:destroy target in nx.json:53 to skip confirmation prompts when running destroy commands in non-TTY environments (e.g., nx run-many -t cdk:destroy --all).

Middleware Environment Configuration
Updated middleware app.ts files to pass environment configuration for account and region, matching the pattern used in clients and services:

app.ts
app.ts
Both now properly interpolate CDK_DEFAULT_ACCOUNT, CDK_DEFAULT_REGION, AWS_ACCOUNT_ID, and AWS_REGION environment variables when deploying stacks.

hxtree and others added 10 commits December 18, 2025 20:18
- Fix promare-gradients SCSS map formatting and phi calculation syntax
- Update RemovalPolicy from invalid RETAIN_ON_UPDATE_OR_DELETE to RETAIN
- Add error handling to setup-aws-cdk-env.sh script
* fix: correct SCSS syntax by closing math.div on same line

Co-authored-by: hxtree <19890291+hxtree@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances AWS CDK deployment infrastructure by adding environment configuration to middleware and services, improving the CDK workflow tooling, and upgrading several dependencies.

Key changes:

  • Added environment variable interpolation (CDK_DEFAULT_ACCOUNT, CDK_DEFAULT_REGION, AWS_ACCOUNT_ID, AWS_REGION) to all CDK app.ts files for proper account/region targeting
  • Added --force flag to CDK destroy commands in nx.json for non-interactive execution
  • Created a new AWS setup script (setup-aws-cdk-env.sh) to handle authentication and credential export

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/scripts/setup-aws-cdk-env.sh New bash script to set up AWS credentials and environment variables for CDK commands
nx.json Added CDK target definitions (deploy, destroy, diff, synth, bootstrap) with proper dependencies and the new setup script
services/*/bin/app.ts Added environment configuration to all service CDK stacks for explicit account/region specification
middleware/*/bin/app.ts Added environment configuration to middleware CDK stacks (api, graphql)
platform/*/bin/app.ts Added environment configuration to platform CDK stacks (message-bus, lambda-layers, pipeline)
clients/*/bin/app.ts Added environment configuration to client CDK stacks
services/*/project.json Added CDK target placeholders for services using CDK
platform/*/project.json Added CDK target placeholders for platform components
clients/*/project.json Added CDK target placeholders for clients
services/*/package.json Updated aws-cdk and aws-cdk-lib versions (contains version issues)
platform/*/package.json Updated aws-cdk and aws-cdk-lib versions (contains version issues)
middleware/*/package.json Updated aws-cdk and aws-cdk-lib versions (contains version issues)
clients/*/package.json Updated aws-cdk and aws-cdk-lib versions (contains version issues)
.nvmrc Updated Node.js version from 18.18.0 to 20.9.0
.github/workflows/*.yml Updated Node.js version to 20.9.0 and actions/cache to v4
libraries/promare-gradients/src/scss/*.scss Migrated from deprecated Sass division to math.div()
libraries/promare-gradients/package.json Migrated from node-sass to Dart Sass
platform/constructs/src/nestjs/nestjs.ts Updated Lambda runtime from NODEJS_18_X to NODEJS_20_X
platform/lambda-layers/stacks/*.stack.ts Updated Lambda runtimes and bundling images
platform/message-bus/stacks/message-bus.stack.ts Updated S3 bucket naming to include "message-bus"
services//stacks/snapshots/.snap Updated snapshots for runtime changes and CDK library updates
README.md Added documentation for deploying individual services

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants