refactor(toggle-group): use Svelte 5 createContext for type-safe context - #2445
Open
braden-w wants to merge 1 commit into
Open
refactor(toggle-group): use Svelte 5 createContext for type-safe context#2445braden-w wants to merge 1 commit into
braden-w wants to merge 1 commit into
Conversation
Replace manual setContext/getContext wrapper functions with Svelte 5's createContext factory. This provides automatic type safety without requiring string keys or explicit type annotations.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the manual
setContext/getContextwrapper functions with Svelte 5'screateContextfactory in the toggle-group component.The new pattern from the Svelte 5 docs provides automatic type safety without requiring string keys or explicit type annotations:
The consumer (
toggle-group-item.svelte) doesn't require any changes since thegetToggleGroupCtx()API remains identical.This is a pure refactor with no behavioral changes.